Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMO upgrade tests pipeline #617

Merged

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Jan 16, 2024

This change is needed for the new jenkins job, which runs BMO E2E upgrade tests.
Related jjb changes: https://gerrit.nordix.org/c/infra/cicd/+/20387

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2024
@mquhuy mquhuy force-pushed the mquhuy/add-bmo-upgrade-pipeline branch from 755c0ac to 9eff209 Compare January 16, 2024 12:18
@mquhuy
Copy link
Member Author

mquhuy commented Jan 16, 2024

/metal3-bmo-e2e-test

Comment on lines 11 to 15
def GINKGO_FOCUS = ""

if (TEST_SET == "e2e-upgrade-test") {
GINKGO_FOCUS="upgrade"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have GINKGO_FOCUS directly as a parameter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if jjb allows that :-?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mquhuy mquhuy requested a review from lentzi90 January 17, 2024 06:56
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/add-bmo-upgrade-pipeline branch from 9eff209 to 3fe126a Compare January 17, 2024 08:19
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Hold until the gerrit PR is merged
/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rozzii
Copy link
Member

Rozzii commented Jan 18, 2024

/test-ubuntu-integration-main

@lentzi90
Copy link
Member

Gerrit merged
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@metal3-io-bot metal3-io-bot merged commit becba49 into metal3-io:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants