Build ironic locally when running tests on ironic-image repo #694
Conversation
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/XS
| @@ -54,13 +54,10 @@ KUBERNETES_VERSION_UPGRADE_FROM="${KUBERNETES_VERSION_UPGRADE_FROM:-}" | |||
| KUBERNETES_VERSION_UPGRADE_TO="${KUBERNETES_VERSION_UPGRADE_TO:-}" | |||
| KUBECTL_SHA256="${KUBECTL_SHA256:-}" | |||
|
|
|||
| if [[ "${IRONIC_INSTALL_TYPE}" == "source" ]]; then | |||
| # Build ironic locally when running tests on ironic-image repo | |||
| if [[ "${REPO_NAME}" == "ironic-image" ]]; then | |||
There was a problem hiding this comment.
We do not want to always build from source. RPM installation is the default method, source building is special case.
We need to have source build triggerable via a keyword for those special cases, and default should stay RPM based install. It will still build the ironic container with the changes via tested_repo, as we can see from the e2e keyword tested yesterday, since metal3-io/ironic-image#495 failed as it depends on metal3-io/ironic-image#493 which succeeded.
/hold
metal3-io-bot
added
the
do-not-merge/hold
|
tests are working as expected building ironic from main by default will be considered |
There is a behavior implimented in old ansible tests to use postfix that make the test building ironic locally even when running on a different repo but it does not seem being used