Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow: Increase max prowjob age to 24h #753

Merged
merged 1 commit into from
May 13, 2024

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented May 13, 2024

Now that we trigger jenkins jobs through Prow, we have some jobs that can take more than 4h. Increasing to 24h.

Edit: I suspect this may be why we have seen some jobs fail but report success (kubernetes-sigs/prow#142). If the prowjob was cleaned up, then what would the jenkins-operator do? 🤔

Now that we trigger jenkins jobs through Prow, we have some jobs that
can take more than 4h. Increasing to 24h.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@mboukhalfa
Copy link
Member

/approve

@lentzi90
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@metal3-io-bot metal3-io-bot merged commit 2866dd6 into metal3-io:main May 13, 2024
6 checks passed
@metal3-io-bot
Copy link
Collaborator

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Now that we trigger jenkins jobs through Prow, we have some jobs that can take more than 4h. Increasing to 24h.

Edit: I suspect this may be why we have seen some jobs fail but report success (kubernetes-sigs/prow#142). If the prowjob was cleaned up, then what would the jenkins-operator do? 🤔

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smoshiur1237
Copy link
Member

@lentzi90 This change is not solving the issue. I can reproduce the issue in the following jenkins run on the Test PR.

@lentzi90
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants