🐛 Fix IMAGE_LOCATION in build-image.sh #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
mquhuy
force-pushed
the
mquhuy/fix-node-image-build-pipeline
branch
from
a6be787
to
f40f14b
Compare
mboukhalfa
reviewed
Jul 16, 2024
|
/approve |
metal3-io-bot
added
the
approved
Signed-off-by: Huy Mai <huy.mai@est.tech>
mquhuy
force-pushed
the
mquhuy/fix-node-image-build-pipeline
branch
from
f40f14b
to
6a6c8a4
Compare
|
/test metal3-ubuntu-e2e-integration-test-main |
|
@mquhuy, now I remember one issue I faced. |
Rozzii
approved these changes
Jul 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboukhalfa, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_image_building is currently failing because the location of the file is incorrect. The built image locates in the directory, from where the script is run (which is the repo root), while the verify script assumes that image locates in
jenkins/image_building.This PR fixes the IMAGE_LOCATION, so that dev-env could find the image.
Edit: Also add the
${IMAGE_NAME}.ddirectory cleanup. This directory was created as a part of the image building.