-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix IMAGE_LOCATION in build-image.sh #816
🐛 Fix IMAGE_LOCATION in build-image.sh #816
Conversation
a6be787
to
f40f14b
Compare
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit
Signed-off-by: Huy Mai <huy.mai@est.tech>
f40f14b
to
6a6c8a4
Compare
/test metal3-ubuntu-e2e-integration-test-main |
@mquhuy, now I remember one issue I faced. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboukhalfa, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
node_image_building is currently failing because the location of the file is incorrect. The built image locates in the directory, from where the script is run (which is the repo root), while the verify script assumes that image locates in
jenkins/image_building
.This PR fixes the IMAGE_LOCATION, so that dev-env could find the image.
Edit: Also add the
${IMAGE_NAME}.d
directory cleanup. This directory was created as a part of the image building.