Update slidding to take in count time_sequence param #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+Add an assert to check nbframe is possible in sequence + Add parameter to self.sequence_time to self._get_frames() method -> That change are complement to generator change
Add optional param seq_time to _get_frames() method to use it only on sliding Add line to get fps Add ternary to calcul frame_step with end video or time_sequence
Update generator.py
Update sliding.py
|
I test generator still working with image resuming the complete video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im not an python OOP expert and i am some tired but i think i have correct the bug reported
[SlidingFrameGenerator] Sequence_time not working #32
I am new on github an i don't know the procedure to propose a bug solution
It think this solution need to be test an other time and is not the best solution
I had a ternary to send to the _get_frames method the sequence_time or 0 if is none
I had some correct to on the generator file to add this optionnal parameter and calcul the new step using all video is the param is none or using juste the fixed sequence