Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka splitting #2740

Merged
merged 38 commits into from
Oct 11, 2024
Merged

Kafka splitting #2740

merged 38 commits into from
Oct 11, 2024

Conversation

Razz4780
Copy link
Contributor

@Razz4780 Razz4780 commented Sep 6, 2024 •
edited
Loading

Issue #2601

I did not reuse MirrordWorkloadQueueRegistry, mostly because SplitQueue is an internally tagged enum and adding another variant breaks mirrord operator setup due to schemars limitations.

Besides that, kafka CRDs are a bit different than SQS:

  1. Target workload is specified via (apiVersion,kind,name) tuple, which should make adding more workload types easier.
  2. Lists are used instead of maps, which k8s people advise (afaik)
  3. The user can specify multiple env vars to patch with a list of (container, variable) pairs
  4. The user can specify timeout for workload patch

I think we can merge MirrordKafkaTopicsConsumer into MirrordWorkloadQueueRegistry when stuff is stable. Wdyt?

@Razz4780 Razz4780 marked this pull request as ready for review October 4, 2024 15:57
@Razz4780 Razz4780 requested a review from t4lz October 4, 2024 16:15
t4lz
t4lz reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@t4lz t4lz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Still going over the operator side.

mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Outdated Show resolved Hide resolved
mirrord/config/src/feature/split_queues.rs Show resolved Hide resolved
t4lz
t4lz approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@t4lz t4lz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Razz4780 Razz4780 added this pull request to the merge queue Oct 11, 2024
@Razz4780 Razz4780 removed this pull request from the merge queue due to a manual request Oct 11, 2024
@Razz4780 Razz4780 added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@Razz4780 Razz4780 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into metalbear-co:main with commit 6b3b4fe Oct 11, 2024
17 checks passed
@Razz4780 Razz4780 deleted the kafka-splitting branch October 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t4lz t4lz t4lz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razz4780 @t4lz