Better error for invalid certificate.

[meowjesty]

• Issue: Detect invalid certificate error and print better message #2824

Improves the error logs, should be more specific now in case of an InvalidCertificate.

[Razz4780]

I'd move detecting invalid cert error to CliError. It offers better support for help messages/fix instructions. See CliError::KubeAuthExecFailed and CliError::auth_exec_error_or. I'd inject new logic into this function

[meowjesty]

Moved the error.

This error feels like it's nested deep into some boxes, and I'm not sure how to reproduce the issue to get the error, that's why I'm a bit unsure on how to go about downcast. Do you know how to get an invalid cert error, so I can change it to downcast instead of checking if error contains a string?

[Razz4780]

Moved the error.

This error feels like it's nested deep into some boxes, and I'm not sure how to reproduce the issue to get the error, that's why I'm a bit unsure on how to go about downcast. Do you know how to get an invalid cert error, so I can change it to downcast instead of checking if error contains a string?

I'd try something like this in the test:

1. Setup an HTTPS server (responds with whatever on all paths) with a randomly generated self-signed certificate
2. Pass its address as cluster_url in kube::Config
3. Create a kube client and try listing pods

[Razz4780]

I'd generate the test cert at runtime, but file is also fine by me