-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error for invalid certificate. #2852
Better error for invalid certificate. #2852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move detecting invalid cert error to CliError
. It offers better support for help messages/fix instructions. See CliError::KubeAuthExecFailed
and CliError::auth_exec_error_or
. I'd inject new logic into this function
Moved the error. This error feels like it's nested deep into some |
I'd try something like this in the test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd generate the test cert at runtime, but file is also fine by me
…4/better-error-for-invalid-certificate
Improves the error logs, should be more specific now in case of an
InvalidCertificate
.