Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Environment parsing when value contained '=' #387

Merged
merged 6 commits into from
Sep 11, 2022

Conversation

DmitryDodzin
Copy link
Member

If env variable contains '=' in it's value then the GetEnvVarsResponse is completely messed up with the key being the last env variable

Example:

PG_CONNECTION=postgres://localhost/?ssl_mode=disable

generates response

DaemonMessage::GetEnvVarsResponse {
    ...
    "postgres://localhost/?ssl_mode": "disable",
    ...
}!

@aviramha
Copy link
Member

Looks good! Please add this env to the e2e as well.

@DmitryDodzin DmitryDodzin merged commit d5cbf43 into metalbear-co:main Sep 11, 2022
@DmitryDodzin DmitryDodzin deleted the fix-env-parsing branch September 11, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants