Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add digitalocean_incidents #9

Merged
merged 2 commits into from
Aug 6, 2020
Merged

add digitalocean_incidents #9

merged 2 commits into from
Aug 6, 2020

Conversation

circa10a
Copy link
Collaborator

Add a gauge to monitor the number of active incidents with digitalocean services.
Sourced from their status api

@metalmatze
Copy link
Owner

Nice! That's definitely super handy!
Is that API not part of godo?

@circa10a
Copy link
Collaborator Author

@metalmatze Sadly, no. That would have made things much simpler!

Their status page service seemed to be the only place, but it has a really great API.

@metalmatze
Copy link
Owner

Ok. Not a blocker at all. Just wanted to check. I'll give it a proper review soon.

Copy link
Owner

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally gotten around to do a proper review!
This is definitely an amazing addition to the project.

I added some comments on the code. Let me know what you think!

As a follow up, I think it would be amazing to even add labels for the regions and components, so that I can alert on DNS in FRA1 being down, cause I ultimately might not care about SFO1 ☺️ Definitely not part of this PR though, just an idea.

collector/incidents.go Outdated Show resolved Hide resolved
collector/incidents.go Outdated Show resolved Hide resolved
@circa10a
Copy link
Collaborator Author

circa10a commented Jul 8, 2020

@metalmatze Addressed both of the issues and added the ability to filter by region. You can test the regional functionality by changing the API URL to the incident history endpoint(if there aren't any active incidents):

const doStatusAPIURL = "https://s2k7tnzlhrpw.statuspage.io/api/v2/incidents.json"

@circa10a
Copy link
Collaborator Author

@metalmatze just a gentle reminder 😇

@metalmatze
Copy link
Owner

@circa10a Thanks.
I just started some free time from work, so maybe in the next week I have some time to work on it. 😊

Copy link
Owner

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this. 👍
Sorry for the long wait, this isn't the top of my priority list most of the time.

@metalmatze metalmatze merged commit d54a115 into metalmatze:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants