Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened proofs 25.5 #3256

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Shortened proofs 25.5 #3256

merged 2 commits into from
Jun 16, 2023

Conversation

GinoGiotto
Copy link
Contributor

@GinoGiotto GinoGiotto commented Jun 16, 2023

Continuation of #3127. Proof minimizer executed between the 25001th and the 25475th theorems that don't have a proof modification is discouraged label in their comment.

No new axiom dependencies are introduced. Scan my min-all branch and compare it to my develop branch for evidence. The result of the comparison should correspond to eb06148 + 4e9fa83.

As announced in #3155 (comment), this is the end of the series. Last theorem analysed is pliguhgr, which is the last theorem of main without a proof modification is discouraged label on it. A total of around 90 kB of memory was saved thanks to these minimizations.

After merging this PR, I'm going to delete most branches in my repository (included my min-all branch), I don't think this is an issue for anybody, but I wanted to notify you in case someone was working with some of them.

@avekens
Copy link
Contributor

avekens commented Jun 16, 2023

... A total of around 90 kB of memory was saved thanks to these minimizations.

That is a remarkable result! Thanks a lot for your work.

@wlammen wlammen merged commit 45cc321 into metamath:develop Jun 16, 2023
@GinoGiotto GinoGiotto deleted the min25.5-NEW branch June 16, 2023 23:32
@david-a-wheeler
Copy link
Member

That's quite remarkable. Thank you so much for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants