-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mathbox #3773
Mathbox #3773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theorem cbvmptv
is a good example of a theorem that is used a lot.
I can guess adding one letter to the theorem name will shift a lot of compressed proofs.
Why not just make your version of cbvmptv
the official one and set the current to "OLD" ?
It's fine with me. Actually it would probably be a lot easier to do it this way (and it would generate less amount of changes). If you want, I can make a list of the most used additional lemmas and do the same for them (I have to check that it works before following this approach). The only things we have to consider is that some of them might be used by other additional lemmas and that not all replacements are admitted. In ax-13-complete I verified that Ok, with a quick look it seems doable. |
Update: on branch https://github.com/GinoGiotto/set.mm/tree/cbvmptv I posted this commit showing how the PR would look like (then I would also add the OLD version). |
~cbvmptvw requires x and y to bis distinct, whereas ~cbvmptv does not. So only 3 of the 444 usages of ~cbvmptv do not depend on this detail, and therefore the replacement can be done without additial changes? Since the original ~cbvmptv is used and therefore is still required, it should not be declared as OLD (which would mean that it should be removed after a year), but renamed with a proper label. |
The necessary changes to make the verifiers green are only these and rewrap.
It depends which way you want to see it. |
Are those DV which would be added "useless" ones, in the sense that they affect set variables which actually don't appear in the final theorem statement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After analysing the commit 6a865d0, I see no problems in changing the DV conditions of the theorems currently using ~ cbvmptv:
- ~rdgsucmpt2 uses both x and y in the hypotheses, but the purpose of this theorem is to keep these variables distinct, so they can be declared as distinct, too.
- ~frsucmpt2 same arguments as for ~rdgsucmpt2
- ~tendo0cbv, ~tendo02, ~tendo0cl: Norm's mathbox, so we unfortunately will not get feedback by the author. ~tendo0cbv seems to be unneccesary anyway, the statements and hypotheses of ~tendo02 and ~ tendo0cl only contain f, so g is actually only an auxiliary variable.
- 0ome: only the hypothesis contains one of the variables (x), so y is actually only an auxiliary variable.
Therefore, it will not be a problem to repace the current ~cbvmptv by ~cbvmptvw and mark the current ~cbvmptv as OLD.
Can we keep it as an ALT instead so we can demonstrate how to do it without DVs?On Jan 17, 2024, at 10:20 AM, avekens ***@***.***> wrote:
@avekens approved this pull request.
After analysing the commit 6a865d0,
I see no problems in changing the DV conditions of the theorems currently using ~ cbvmpt:
~rdgsucmpt2 uses both x and y in the hypotheses, but the purpose of this theorem is to keep these variables distinct, so they can be declared as distinct, too.
~frsucmpt2 same arguments as for ~rdgsucmpt2
~tendo0cbv, ~tendo02, ~tendo0cl: Norm's mathbox, so we unfortunately will not get feedback by the author. ~tendo0cbv seems to be unneccesary anyway, the statements and hypotheses of ~tendo02 and ~ tendo0cl only contain f, so g is actually only an auxiliary variable.
0ome: only the hypothesis contains one of the variables (x), so y is actually only an auxiliary variable.
Therefore, it will not be a probmel to repace the current ~cbvmptv by ~cbvmptvw and mark the current ~cbvmptv as OLD.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
That's not an issue for me. Btw in the meantime I noticed that we can use the same trick for cbvmpt, which is currently used directly by 116 theorems, and it works for cbvmptf and cbvopab1 as well. All these together would require the addition of 8 dv conditions instead of 6. On branch cbvmptv_2 I pushed the following commit 53d419b verifying that it passes all checks (I also removed a few unnecessary dv from cbvmpt). I didn't read this message yet, so I put OLD proofs. I can change them to ALT if desired. |
ALT works for me too! |
@GinoGiotto Can I merge this, or would you prefer to first rework it? |
Merge, I'll rework in the next PR. |
Removed intemediate lemma dvelimfw. In ax-13-complete it's used only once and only by another of my lemmas.
Corrections to the comments of cbval2vw and cbvex2vw.
Added proof chain that leads to
cbvmptvw
, which is the most used additional theorem in ax-13-complete (it has 443 direct usages).