Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French SI Brochure feedback from BIPM (pages 82-104-Index) #44

Closed
ronaldtse opened this issue Oct 30, 2020 · 15 comments
Closed

French SI Brochure feedback from BIPM (pages 82-104-Index) #44

ronaldtse opened this issue Oct 30, 2020 · 15 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

page comment
82 2nd bullet point in first list: replace "mètre" by "mètres"
82 use comma as decimal separator for all  numbers
83 3rd bullet point from bottom: pi not in italics
83 last bullet point from bottom : M in M(12C) in italics
82 CIPM 2013: isolated » at beginning of line
85 1st bullet point following "recommande": change to 6s2  1S0  –  6s  6p  3P0
85 2nd bullet point: 4s   2S1/2   –   3d 2D5/2
85 3rd bullet point: 6s 2S1/2 – 4f 13  6s2  2F7/2
85 3rd bullet point : 6s2  1S0 – 6s 6p 3P0
85 3rd bullet point: use comma as decimal separator for all numbers
85 last bullet point: 3s2 1S0  – 3s 3p 3P0
85 last bullet point: use comma as decimal separator
86 1st bullet point:  5d10 6s 2S1/2  –  5d9 6s2 2D5/2
86 1st bullet point: use comma as decimal separator for all numbers
86 2nd bullet point: 6s 2S1/2 (F = 0, mF = 0) – 5d  2D3/2 (F = 2, mF = 0)
86 3rd bullet point: 5s  2S1/2 – 4d 2D5/2
86 4th bullet point: 5s2 1S0  –  5s 5p 3P0
86 Resolution 1: 1st paragraph, e in italics
87 Recommendation 2 : also here, all identification of the optical transitions have errors with the subscripts and superscripts. Please refer to the SI brochure.
87 Recommendation 2: use the comma as decimal separator for all numbers
87 last bullet point: accent missing on "octopôle".
88 first bullt point: addent missing on "quadrupôle"
88 two bullet points following "recommande": "Les valeurs" too far on the left
89 Resolution 1, list of constants: use comma as decimal separator for the value of the Avogadro constant
90 "Annexe 1" missing in first title
90 "Annex 2" missing in second title
90 4th bullet point from bottom: h in italics
90 3rd bullet point from botton: pi not in italics
90 2nd bullet point from bottom: replace TTPW by TTPW
90 last bullet point: M italics
91 "Annex 3" missing in title
91 group decimals after decimal separator  by three, for all numbers
94 Can we keep "Partie 1" in the title, without creating a separate entry in the Table of Contents? Analogous for "Partie 2" and "Partie 3".
95 4th paragraph: isolated » at beginning of line
99 first paragraph: Metrologia in italics
99 second paragraph: Metrologia in italics
100 3rd paragraph: isolated » at beginning of line
100 last paragraph: isolated « at end of line
100 last paragraph, 5th line: wrong symbol for °K
101 first paragraph:  isolated « at end of line
101 2nd paragraph: N in italics
101 3rd paragraph: isolated « at end of line
101 last paragraph: isolated « at end of line
104 entry for SUNAMCO: text wrongly distributed over columns
INDEX The index is missing
@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Oct 31, 2020

page comment to fix
82 2nd bullet point in first list: replace "mètre" by "mètres adoc
82 use comma as decimal separator for all numbers adoc
83 3rd bullet point from bottom: pi not in italics adoc
83 last bullet point from bottom : M in M(12C) in italics adoc
82 CIPM 2013: isolated » at beginning of line adoc
85 1st bullet point following "recommande": change to 6s2 1S0 – 6s 6p 3P0 adoc
85 2nd bullet point: 4s 2S1/2 – 3d 2D5/2 adoc
85 3rd bullet point: 6s 2S1/2 – 4f 13 6s2 2F7/2 adoc
85 3rd bullet point : 6s2 1S0 – 6s 6p 3P0 adoc
85 3rd bullet point: use comma as decimal separator for all numbers adoc
85 last bullet point: 3s2 1S0 – 3s 3p 3P0 adoc
85 last bullet point: use comma as decimal separator adoc
86 1st bullet point: 5d10 6s 2S1/2 – 5d9 6s2 2D5/2 adoc
86 1st bullet point: use comma as decimal separator for all numbers adoc
86 2nd bullet point: 6s 2S1/2 (F = 0, mF = 0) – 5d 2D3/2 (F = 2, mF = 0) adoc
86 3rd bullet point: 5s 2S1/2 – 4d 2D5/2 adoc
86 4th bullet point: 5s2 1S0 – 5s 5p 3P0 adoc
86 Resolution 1: 1st paragraph, e in italics adoc
87 Recommendation 2 : also here, all identification of the optical transitions have errors with the subscripts and superscripts. Please refer to the SI brochure. adoc
87 Recommendation 2: use the comma as decimal separator for all numbers adoc
87 last bullet point: accent missing on "octopôle". adoc
88 first bullt point: addent missing on "quadrupôle" adoc
88 two bullet points following "recommande": "Les valeurs" too far on the left adoc or xslt
89 Resolution 1, list of constants: use comma as decimal separator for the value of the Avogadro constant adoc
90 "Annexe 1" missing in first title adoc
90 "Annex 2" missing in second title adoc
90 4th bullet point from bottom: h in italics adoc
90 3rd bullet point from botton: pi not in italics adoc
90 2nd bullet point from bottom: replace TTPW by TTPW adoc
90 last bullet point: M italics adoc
91 "Annex 3" missing in title adoc
91 group decimals after decimal separator by three, for all numbers adoc
94 Can we keep "Partie 1" in the title, without creating a separate entry in the Table of Contents? Analogous for "Partie 2" and "Partie 3". adoc
95 4th paragraph: isolated » at beginning of line adoc
99 first paragraph: Metrologia in italics adoc
99 second paragraph: Metrologia in italics adoc
100 3rd paragraph: isolated » at beginning of line adoc
100 last paragraph: isolated « at end of line adoc
100 last paragraph, 5th line: wrong symbol for °K adoc
101 first paragraph: isolated « at end of line adoc
101 2nd paragraph: N in italics adoc
101 3rd paragraph: isolated « at end of line adoc
101 last paragraph: isolated « at end of line adoc
104 entry for SUNAMCO: text wrongly distributed over columns adoc
INDEX The index is missing ?

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Oct 31, 2020

Regarding issue

page comment to fix
88 two bullet points following "recommande": "Les valeurs" too far on the left adoc or xslt

In the document there are a few definition lists (dl) in list items:

Resulted PDF:

изображение

Source PDF:

изображение

Resulted PDF:

изображение

Source PDF:

изображение

Second example in the source PDF is centered definition list. If we add a left margin to dl in list items, then the resulted PDF looks ok:

Updated resulted PDF:

изображение

BUT we get the same margin for first example:

Updated resulted PDF:

изображение

We need to code these lists differently. Could we mark dl as align="center"?

@opoudjis
Copy link
Contributor

opoudjis commented Nov 1, 2020

I reject the notion of centering dl's: Metanorma is not Word, and is not going to support open-ended free formatting. In any case, what is happening here is not a centered dl, it is a dl nested within a list entry, so:

* Molecules blah blah
+
----
Les valeurs:: f_a1_ ...
----

Won't an embedded ul/li/dl take care of this?

@Intelligent2013
Copy link
Contributor

Won't an embedded ul/li/dl take care of this?

In this case it's enough.
But there is case with similar markup:

. Les unités photométriques peuvent être définies comme suit:
+
--
*_Bougie nouvelle_* (unité d’intensité lumineuse).:: La grandeur de la bougie nouvelle est telle
que la brillance du radiateur intégral à la température de solidification du platine soit de
60 bougies nouvelles par centimètre carré.

*_Lumen nouveau_* (unité de flux lumineux).:: Le lumen nouveau est le flux lumineux émis dans
l’angle solide unité (stéradian) par une source ponctuelle uniforme ayant une intensité
lumineuse de 1 bougie nouvelle.
--

And it shows in source PDF without indent:
изображение

@ronaldtse It's ok if we'll show it with indents? :
изображение

@opoudjis
Copy link
Contributor

opoudjis commented Nov 1, 2020

Or alternatively, don't treat it as a definition list at all: they haven't...

@manuelfuenmayor manuelfuenmayor self-assigned this Nov 2, 2020
@manuelfuenmayor
Copy link
Contributor

82 | 2nd bullet point in first list: replace "mètre" by "mètres | adoc

83 | last bullet point from bottom : M in M(12C) in italics | adoc

82 | CIPM 2013: isolated » at beginning of line | adoc

86 | Resolution 1: 1st paragraph, e in italics | adoc

87 | last bullet point: accent missing on "octopôle". | adoc

88 | first bullt point: addent missing on "quadrupôle" | adoc

90 | 2nd bullet point from bottom: replace TTPW by TTPW | adoc

90 | last bullet point: M italics | adoc

95 | 4th paragraph: isolated » at beginning of line | adoc

99 | first paragraph: Metrologia in italics | adoc

99 | second paragraph: Metrologia in italics | adoc

100 | 3rd paragraph: isolated » at beginning of line | adoc

100 | last paragraph: isolated « at end of line | adoc

100 | last paragraph, 5th line: wrong symbol for °K | adoc

101 | first paragraph: isolated « at end of line | adoc

101 | 2nd paragraph: N in italics | adoc

101 | 3rd paragraph: isolated « at end of line | adoc

101 | last paragraph: isolated « at end of line | adoc

104 | entry for SUNAMCO: text wrongly distributed over columns | adoc

All fixed.

90 | "Annexe 1" missing in first title | adoc

90 | "Annex 2" missing in second title | adoc

91 | "Annex 3" missing in title | adoc

I have put "Annexe 1", "Annexe 2" and "Annexe 3" explicitly in the corresponding section titles.

94 | Can we keep "Partie 1" in the title, without creating a separate entry in the Table of Contents? Analogous for "Partie 2" and "Partie 3". | adoc

Added "Partie 1" in title. Fixed.

83 | 3rd bullet point from bottom: pi not in italics | adoc

90 | 4th bullet point from bottom: h in italics | adoc

90 | 3rd bullet point from botton: pi not in italics | adoc

Not fixable by markup.

82 | use comma as decimal separator for all numbers | adoc

85 | 3rd bullet point: use comma as decimal separator for all numbers | adoc

85 | last bullet point: use comma as decimal separator | adoc

86 | 1st bullet point: use comma as decimal separator for all numbers | adoc

87 | Recommendation 2: use the comma as decimal separator for all numbers | adoc

89 | Resolution 1, list of constants: use comma as decimal separator for the value of the Avogadro constant | adoc

91 | group decimals after decimal separator by three, for all numbers | adoc

I believe these are suposed to be handled automatically.

85 | 1st bullet point following "recommande": change to 6s2 1S0 – 6s 6p 3P0 | adoc

85 | 2nd bullet point: 4s 2S1/2 – 3d 2D5/2 | adoc

85 | 3rd bullet point: 6s 2S1/2 – 4f 13 6s2 2F7/2 | adoc

85 | 3rd bullet point : 6s2 1S0 – 6s 6p 3P0 | adoc

85 | last bullet point: 3s2 1S0 – 3s 3p 3P0 | adoc

86 | 1st bullet point: 5d10 6s 2S1/2 – 5d9 6s2 2D5/2 | adoc

86 | 2nd bullet point: 6s 2S1/2 (F = 0, mF = 0) – 5d 2D3/2 (F = 2, mF = 0) | adoc

86 | 3rd bullet point: 5s 2S1/2 – 4d 2D5/2 | adoc

86 | 4th bullet point: 5s2 1S0 – 5s 5p 3P0 | adoc

87 | Recommendation 2 : also here, all identification of the optical transitions have errors with the subscripts and superscripts. Please refer to the SI brochure. | adoc

These cases are rendering well in HTML but not in PDF. @Intelligent2013?

88 | two bullet points following "recommande": "Les valeurs" too far on the left | adoc or xslt

In HTML renders fine, but not in PDF. @Intelligent2013?

INDEX | The index is missing | ?

I believe this refers to the lack of an alphabetical index in the generated output. @opoudjis ?

@manuelfuenmayor
Copy link
Contributor

Fixes are in #45

@opoudjis
Copy link
Contributor

INDEX | The index is missing | ?
I believe this refers to the lack of an alphabetical index in the generated output. @opoudjis ?

Yes, and I got bad news for you.

Yes, we can add index markup to Metanorma: we have done it for IETF. I would not want to be @Intelligent2013 implementing it, and I'd be assiduously avoiding implementing it myself. And index generation is going to be a horrific amount of markup for you to do.

@ronaldtse I'd like for you to confirm that indexing is a requirement, and it's not going to be quick if we do do it.

@ronaldtse
Copy link
Contributor Author

@opoudjis Yes, the index is a requirement. We've been avoiding it for quite some time and this seems like a good time to introduce this. I assume the index will be included in Presentational XML.

@opoudjis
Copy link
Contributor

opoudjis commented Nov 17, 2020

I assume the index will be included in Presentational XML.

... Gee. Thanks.

Presumably it will be realised in Presentation XML as the page-only cross-references we have already been bludgeoned by BIPM into producing.

metanorma/metanorma-bipm#67

@manuelfuenmayor
Copy link
Contributor

manuelfuenmayor commented Dec 1, 2020

Based on the latest PDF provided by @opoudjis: si-brochure-fr(12-01).pdf

Issues fixed recently:

page comment issue
85 3rd bullet point : 6s2  1S0 – 6s 6p 3P0 fixed in #59
86 2nd bullet point: 6s 2S1/2 (F = 0, mF = 0) – 5d  2D3/2 (F = 2, mF = 0) fixed in #59
90 4th bullet point from bottom: h in italics fixed in #59

Remaining issues:

page comment issue
83 last bullet point from bottom : M in M(12C) in italics not fixed
90 last bullet point: M italics not fixed
101 2nd paragraph: N in italics not fixed
INDEX The index is missing not fixed

Additional issues that weren't before:

  • Italics was removed for the N letter in stem blocks (stem:[N]):
    issue1

  • Cursive K in math (stem:[cc "K"]) is not rendering as expected:
    Generated:
    issue2
    Original:
    issue2-original

@Intelligent2013
Copy link
Contributor

Cursive K in math (stem:[cc "K"]) is not rendering as expected:

Very strange. In my environment (Win7) it generated ok:
изображение

Looks like it occurs for <mstyle mathvariant="script">...., but one font STIX Two Math is using for all maths...

@opoudjis
Copy link
Contributor

opoudjis commented Dec 4, 2020

@Intelligent2013 Since I generated the PDF, the issue is my side. Could you please tell me what to check?

@manuelfuenmayor
Copy link
Contributor

manuelfuenmayor commented Dec 4, 2020

Two remaining issues:

page comment issue
101 2nd paragraph: N in italics fixed in #59
INDEX The index is missing not fixed

@anermina
Copy link
Contributor

anermina commented Dec 8, 2020

Issue metanorma/metanorma-bipm#67 is opened to address adding index. Closing this one.

@anermina anermina closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants