PR landing tool #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
reviewed
Apr 18, 2019
lundibundi
reviewed
Apr 18, 2019
lundibundi
reviewed
Apr 18, 2019
JuliaGerasymenko
force-pushed
the
pr-landing-tool
branch
2 times, most recently
from
f0c401c to
a56cca9
Compare
JuliaGerasymenko
force-pushed
the
pr-landing-tool
branch
2 times, most recently
from
20d9106 to
1c4f395
Compare
belochub
reviewed
Jun 14, 2019
JuliaGerasymenko
force-pushed
the
pr-landing-tool
branch
5 times, most recently
from
5c0e1de to
2ec3867
Compare
lundibundi
reviewed
Jun 23, 2019
lundibundi
reviewed
Jun 23, 2019
lundibundi
reviewed
Jun 27, 2019
| git = await exec(`git log -${count} --pretty=format:%h`); | ||
| } catch (error) { | ||
| console.error(error); | ||
| process.exit(1); |
There was a problem hiding this comment.
Nit: I'd prefer to handle these errors (here and in differCommits, currentBranch, getRepoName) at the calling site to avoid duplicate code (i.e. console.error(error); process.exit(1)).
bin/land.js
Outdated
| async function getRepoName() { | ||
| let git, | ||
| name = 'origin'; | ||
| args.forEach(value => { |
There was a problem hiding this comment.
for (const value of args) {
if (value.startsWith('--remote-name')) {
name = value.split('=')[1];
}
}
JuliaGerasymenko
force-pushed
the
pr-landing-tool
branch
from
dd91e99 to
293848c
Compare
JuliaGerasymenko
force-pushed
the
pr-landing-tool
branch
from
ee88771 to
062d83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.