-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metasfresh - procurement audit #12600
metasfresh - procurement audit #12600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have some remarks for a follow-up..will put them into an issue..
LE: we should also have a scheduled process that deletes audit-records past a certain age
@NonNull Object content; | ||
@Nullable String eventUUID; | ||
@Nullable String relatedEventUUID; | ||
@Nullable IHostIdentifier host; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it would make sense to also have a property for indicating the service on which the "in" or "out" happened (app or webapi).
Then we could also use this for intra-metasfresh-auditing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, we might add a "status", like success, warning or error..and in the case of error we might have an AD_Issue_ID
} | ||
catch (final JsonProcessingException e) | ||
{ | ||
logger.warn("Failed converting `{}` to JSON. Returning toString().", content, e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, instead of cluttering the console, we might ceate the entry with status="Warn" and an ad_issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shall not happen
} | ||
catch (final Exception ex) | ||
{ | ||
logger.warn("Failed converting message to JSON: {}. Returning toString().", message, ex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we could again create an ad_issue and create the record with status="Warn"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shall not happen
{ | ||
return; | ||
} | ||
|
||
final PutBPartnersRequest syncBPartnersRequest = PutBPartnersRequest.of(syncBPartner); | ||
agent.syncBPartners(syncBPartnersRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should record this in the export audit log, and make sure to have a reference between it and the RabbitMQ_Message_Audit record
Audit on metasfresh side
Audit on procurement side