Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): reduce union/either variant if required in apply syntax #463

Merged
merged 15 commits into from
Oct 25, 2023
Merged

fix(sdk): reduce union/either variant if required in apply syntax #463

merged 15 commits into from
Oct 25, 2023

Conversation

michael-0acf4
Copy link
Contributor

No description provided.

@michael-0acf4 michael-0acf4 marked this pull request as draft October 20, 2023 15:47
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e57ea9b) 80.33% compared to head (83a5168) 80.33%.
Report is 1 commits behind head on main.

❗ Current head 83a5168 differs from pull request most recent head 5093aa9. Consider uploading reports for the commit 5093aa9 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files          91       91           
  Lines       10408    10408           
  Branches     1186     1186           
=======================================
  Hits         8361     8361           
  Misses       2027     2027           
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-0acf4 michael-0acf4 changed the title fix(sdk): pick correct union/either variant in apply syntax fix(sdk): reduce union/either variant if required in apply syntax Oct 23, 2023
@michael-0acf4 michael-0acf4 requested review from zifeo and Natoandro and removed request for zifeo October 24, 2023 14:38
@michael-0acf4 michael-0acf4 marked this pull request as ready for review October 25, 2023 10:51
@Natoandro Natoandro merged commit 4923e53 into main Oct 25, 2023
10 checks passed
@Natoandro Natoandro deleted the MET-275-sdk-apply-bug branch October 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zifeo zifeo zifeo left review comments

@Natoandro Natoandro Natoandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-0acf4 @zifeo @Natoandro