Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): workflow_dispatch for release wflow #546

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Jan 12, 2024

  • Manual trigger for release wflow
  • Adds missing ghjk step for vscode-extension release job

Motivation and context

Provides recovery path for when things break.

Migration notes

Doesn't affect end users.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am force-pushed the fix/vscode-release-wflow branch from 927be9b to 06c02fd Compare January 12, 2024 20:58
michael-0acf4
michael-0acf4 previously approved these changes Jan 12, 2024
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Jan 12, 2024

I thought these flakes we're seeing when deno downloads the modules was a problem with deno.land/x but it just flaked out with an npm package. It just might be bug in the deno resolver. Let's be upgrade to latest deno (1.39.2) and ig I'll go looking for a ticket.
image

@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Jan 12, 2024

Strange thing is I've never seen this locally, only on the CI and I've cleaned out my DENO_DIR scores of times over the past week.

@Yohe-Am Yohe-Am requested a review from michael-0acf4 January 12, 2024 21:17
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Jan 12, 2024

Regarding the bug Natondoro run into here, looks like that was indeed a registry issue as discussed here.

Edit: fixed bad url

@Yohe-Am Yohe-Am merged commit c146efa into main Jan 12, 2024
9 checks passed
@Yohe-Am Yohe-Am deleted the fix/vscode-release-wflow branch January 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants