Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): move typegraphs in separate folder + add ts version #552

Merged
merged 49 commits into from
Jan 24, 2024

Conversation

michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Jan 15, 2024

Motivation and context

Better organization + typescript examples.

Migration notes

N/A

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@michael-0acf4 michael-0acf4 changed the title chore(website): move typegraphs in separate folder + add ts version docs(website): move typegraphs in separate folder + add ts version Jan 16, 2024
@michael-0acf4 michael-0acf4 marked this pull request as ready for review January 19, 2024 15:58
Natoandro
Natoandro previously approved these changes Jan 22, 2024
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that checks if they all serializes to the same JSON?

@michael-0acf4 michael-0acf4 dismissed stale reviews from Natoandro and Yohe-Am via b3086e8 January 22, 2024 14:22
@michael-0acf4 michael-0acf4 merged commit 536f07c into main Jan 24, 2024
10 checks passed
@michael-0acf4 michael-0acf4 deleted the move-typegraphs-in-separate-folder branch January 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants