-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upload url path and add logging in the SDK #740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heroic work. Will hopefully be the last major refactor this quarter lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess reverting back to stdout but with a better protocol on top is also worth trying considering the server approach had some overhead and rise in maintenance difficulty. 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 73.06% 73.43% +0.37%
==========================================
Files 116 115 -1
Lines 14150 14022 -128
Branches 1417 1416 -1
==========================================
- Hits 10338 10297 -41
+ Misses 3786 3699 -87
Partials 26 26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo!
Migration notes
The
typegraphs.deno
section of themetatype.yaml
config file has been replaced bytypegraphs.typescript
andtypegraphs.javascript
.tg_deploy
params has changed.The change comes with new or modified tests
Hard-to-understand functions have explanatory comments
End-user documentation is updated to reflect the change