Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: injection on output types (outjection) #935

Merged
merged 13 commits into from
Dec 9, 2024
Merged

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented Dec 2, 2024

  • Solve MET-140
    • Enable injection on output
  • Solve MET-47
    • test from parent injection for either/union types

Migration notes

  • N/A

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Dec 2, 2024

michael-0acf4
michael-0acf4 previously approved these changes Dec 4, 2024
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

luckasRanarison
luckasRanarison previously approved these changes Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (4037040) to head (12ffbdc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/deno/deno.ts 78.68% 13 Missing ⚠️
src/typegate/src/engine/planner/injection_utils.ts 0.00% 7 Missing ⚠️
src/typegate/src/runtimes/graphql.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   77.66%   77.81%   +0.15%     
==========================================
  Files         151      153       +2     
  Lines       18564    18960     +396     
  Branches     1799     1893      +94     
==========================================
+ Hits        14417    14754     +337     
- Misses       4123     4182      +59     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-0acf4
michael-0acf4 previously approved these changes Dec 5, 2024
Yohe-Am
Yohe-Am previously approved these changes Dec 5, 2024
tests/injection/outjection.py Show resolved Hide resolved
tests/injection/outjection.py Show resolved Hide resolved
tests/injection/outjection.py Show resolved Hide resolved
@Natoandro Natoandro dismissed stale reviews from michael-0acf4 and Yohe-Am via 12ffbdc December 9, 2024 12:43
@Natoandro Natoandro merged commit 3643286 into main Dec 9, 2024
12 of 13 checks passed
@Natoandro Natoandro deleted the met-140-context branch December 9, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants