Skip to content

Commit

Permalink
💥 refactor!: Rename executable_version to executable-version.
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This breaks existing usage because it changes the
public API.
  • Loading branch information
make-github-pseudonymous-again committed May 17, 2024
1 parent 7824caf commit cc545eb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci:test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
uses: ./
with:
working-directory: ${{ matrix.test }}
executable_version: ${{ matrix.meteor-version }}
executable-version: ${{ matrix.meteor-version }}

- name: Test (preinstall) 🧪
run: |
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
## `inputs`

### `executable_version` (default: `local`)
### `executable-version` (default: `local`)

Meteor version for the `meteor` executable. See description in
[`action.yml`](action.yml).
Expand Down
8 changes: 4 additions & 4 deletions action.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Install
description: Installs Meteor and npm dependencies
inputs:
executable_version:
executable-version:
description: 'Meteor version for the `meteor` executable. If set to `local` or not explicitly set, the `meteor` executable will have the version specified in .meteor/release (this may not work with alpha and beta builds). You can use `latest` as an alias for the latest Meteor release.'
required: true
default: 'local'
Expand All @@ -26,12 +26,12 @@ runs:
- name: Set env.METEOR_EXECUTABLE_VERSION 📺
shell: bash
run: |
if [ ${{ inputs.executable_version }} = 'local' ]; then
if [ ${{ inputs.executable-version }} = 'local' ]; then
echo "METEOR_EXECUTABLE_VERSION=${{ env.METEOR_LOCAL_RELEASE }}" >> $GITHUB_ENV
elif [ ${{ inputs.executable_version }} = 'latest' ]; then
elif [ ${{ inputs.executable-version }} = 'latest' ]; then
echo "METEOR_EXECUTABLE_VERSION=$(curl -s https://install.meteor.com | sed -n 's/^RELEASE="\(.*\)"$/\1/p')" >> $GITHUB_ENV
else
echo "METEOR_EXECUTABLE_VERSION=${{ inputs.executable_version }}" >> $GITHUB_ENV
echo "METEOR_EXECUTABLE_VERSION=${{ inputs.executable-version }}" >> $GITHUB_ENV
fi
- name: Cache ~/.meteor (Meteor ${{ env.METEOR_EXECUTABLE_VERSION }} (${{ env.METEOR_RELEASE_PATH }} is ${{ env.METEOR_LOCAL_RELEASE }})) 💿
Expand Down

0 comments on commit cc545eb

Please sign in to comment.