Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation doesn't always work #695

Open
petestreet opened this issue Jul 6, 2016 · 0 comments · May be fixed by #697
Open

Validation doesn't always work #695

petestreet opened this issue Jul 6, 2016 · 0 comments · May be fixed by #697

Comments

@petestreet
Copy link

petestreet commented Jul 6, 2016

I've made a custom signin/signup form according to the Guide, and stumbled across a common use case when the field-level validation checks don't actually run. On the "Join" page, if you try submitting the form with a valid username set (before filling in the other inputs), and then change the username input to something invalid, it will let you create that user. The re, minLength, and required checks are all not honored.

See a video of it happening here. You can try it for yourself on this demo app, and can view the code running on that app here.

Since a user can basically bypass any validation checks, this seems like a pretty serious issue.

petestreet added a commit to petestreet/core that referenced this issue Jul 8, 2016
This fixes meteor-useraccounts#695.  Before, fields that previously passed validation didn't have to be re-validated, even if their contents changed, because their `state` would be set to `false` instead of `null`.
@petestreet petestreet linked a pull request Jul 8, 2016 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant