Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML.isArray to work across frames. #276

Merged
merged 5 commits into from
Mar 19, 2021

Conversation

brucejo75
Copy link
Contributor

Title says it all.

See issue #275.

Also, for reference I ran into a similar issue earlier in meteor that was resolved with pr meteor/meteor#8401. I learned the hard way to retain both forms of Array detection 😄 .

@brucejo75
Copy link
Contributor Author

Looks like a build issue?

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
All committers have signed the CLA.

@filipenevola
Copy link
Collaborator

Hi @brucejo75, do you want to have this PR merged yet?

If yes, please comment here so we can re-open, review and merge.

@brucejo75
Copy link
Contributor Author

Sorry, yes I would like this merged... I will take another look if you can reopen.

@filipenevola filipenevola reopened this Mar 15, 2021
@filipenevola
Copy link
Collaborator

@brucejo75 done.

@brucejo75
Copy link
Contributor Author

@filipenevola, I think these are generic build errors? They have nothing to do with my fix... Is someone working on the Blaze regression tests?

Service alert: Your project references CircleCI 1.0 or it has no configuration. CircleCI 1.0 and projects without configuration files are no longer supported. You must update your project to use CircleCI 2.0 configuration to continue. Learn More

An error occurred in .circleci/config.yml

@filipenevola
Copy link
Collaborator

Yes, here #317

Blaze tests were using CircleCI 1.0 but it was deprecated.

@filipenevola
Copy link
Collaborator

Hi, tests are fixed on master. Please update your branch.

@brucejo75
Copy link
Contributor Author

@filipenevola, looks like Blaze Tests succeeded but the 1st 2 checks (CLA, ci/circleci) are stuck?

@filipenevola filipenevola changed the base branch from master to release-2.4 March 19, 2021 20:27
@filipenevola filipenevola merged commit 4ce1f30 into meteor:release-2.4 Mar 19, 2021
@filipenevola
Copy link
Collaborator

@brucejo75 they were the old tests.

brucejo75 added a commit to merisforks/blaze that referenced this pull request Mar 22, 2021
brucejo75 added a commit to merisforks/blaze that referenced this pull request Mar 22, 2021
@filipenevola filipenevola added this to the 2.4 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants