Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some old compat and update dependencies #330

Merged
merged 7 commits into from
Jun 15, 2021

Conversation

StorytellerCZ
Copy link
Collaborator

While looking for old compatibility pre Meteor 1.0 I have found few here in Blaze and have taken the liberty to remove them. At the same time I have also updated the dependencies for the affected packages. Version bump is debatable.

@jankapunkt
Copy link
Collaborator

Looks good to me

Copy link
Collaborator

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@filipenevola filipenevola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are removing code that maybe someone is still using I believe a major would be better but at least a minor would be required for all affected pages, no?

packages/spacebars/package.js Outdated Show resolved Hide resolved
@StorytellerCZ StorytellerCZ requested a review from filipenevola May 5, 2021 15:15
@StorytellerCZ
Copy link
Collaborator Author

@filipenevola That is what needs to be discussed. These are all compatibility workarounds for before 1.0 version. I'm fine with both approaches.

@jankapunkt
Copy link
Collaborator

I would favor a major version bump if old compat is removed, too. However, I am not sure how big the implications are for packages depending on templating@1.x or blaze@2.x. Especially those "unmaintained" ones will definitely become incompatible of those deps are declared, right?

@filipenevola
Copy link
Collaborator

I would favor a major version bump if old compat is removed, too. However, I am not sure how big the implications are for packages depending on templating@1.x or blaze@2.x. Especially those "unmaintained" ones will definitely become incompatible of those deps are declared, right?

This is my concern as well but at least a minor bump we should do on all of them.

Copy link
Collaborator

@filipenevola filipenevola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should have a minor bump. Why don't you agree?

@distalx
Copy link
Contributor

distalx commented May 6, 2021

Minor version bump makes sense to me to keep away from accidentally breaking something.

@StorytellerCZ
Copy link
Collaborator Author

Then I think we have a consensus for minor version bump due to older packages per @jankapunkt comment.
Or we could make this a basis for the next major version of Blaze and get in there also the modernization work that @harryadel is working on.

@StorytellerCZ StorytellerCZ changed the base branch from master to release-2.6 June 15, 2021 09:05
@StorytellerCZ StorytellerCZ merged commit 3471870 into meteor:release-2.6 Jun 15, 2021
@StorytellerCZ StorytellerCZ deleted the remove-old-compat branch June 15, 2021 09:05
StorytellerCZ added a commit that referenced this pull request Jun 15, 2021
Remove some old compat and update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants