-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some old compat and update dependencies #330
Remove some old compat and update dependencies #330
Conversation
Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are removing code that maybe someone is still using I believe a major would be better but at least a minor would be required for all affected pages, no?
@filipenevola That is what needs to be discussed. These are all compatibility workarounds for before 1.0 version. I'm fine with both approaches. |
I would favor a major version bump if old compat is removed, too. However, I am not sure how big the implications are for packages depending on |
This is my concern as well but at least a minor bump we should do on all of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should have a minor bump. Why don't you agree?
Minor version bump makes sense to me to keep away from accidentally breaking something. |
Then I think we have a consensus for minor version bump due to older packages per @jankapunkt comment. |
Remove some old compat and update dependencies
While looking for old compatibility pre Meteor 1.0 I have found few here in Blaze and have taken the liberty to remove them. At the same time I have also updated the dependencies for the affected packages. Version bump is debatable.