Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Promises in #with (closes #469). #471

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

radekmie
Copy link
Collaborator

As mentioned in #469 (comment), this PR adds support for Promises in #with blocks, just like #424 did that for #if and #each.

Note that due to the way #with is implemented, it takes two "cycles" (i.e., awaits) to fully propagate those results. That should not be a problem, as #with is discouraged anyway.

@radekmie radekmie added this to the Blaze 3.0 milestone Sep 13, 2024
@radekmie radekmie linked an issue Sep 13, 2024 that may be closed by this pull request
@jankapunkt
Copy link
Collaborator

jankapunkt commented Sep 13, 2024

Generally approve, however I can't understand why tests do fail. Here is a snipped from the circleci run:

image

This looks like nothing related to this PR 🤔

@radekmie
Copy link
Collaborator Author

Interesting... They all passed locally.

@DblK
Copy link

DblK commented Oct 9, 2024

Any idea when this PR will be merged and available?

@jankapunkt
Copy link
Collaborator

I think someone with permissions needs to rerun the CI or at least check on it. @denihs do you have access to the circleci and check why this failed with this very weird error message?

@denihs
Copy link
Contributor

denihs commented Oct 21, 2024

Sorry for the delay here. Two tests are failing:

image

image

@radekmie
Copy link
Collaborator Author

I tried that locally again and it worked. Then I restarted it and it fails now. I have no idea what's going on, but will try to fix it.

@jankapunkt
Copy link
Collaborator

@radekmie thanks for fixing this 👍

@DblK
Copy link

DblK commented Oct 28, 2024

Hi,
Thanks @radekmie for the fixes.
@StorytellerCZ any idea when this will be merged and published?
This is blocking the deployment on my app in production.

@jankapunkt
Copy link
Collaborator

I can merge but publishing is on the side of the Meteor core team // cc @denihs

@jankapunkt jankapunkt merged commit 7d1b144 into master Oct 28, 2024
2 checks passed
@DblK
Copy link

DblK commented Nov 13, 2024

@denihs any idea when a potential 3.0.1 could be out?
I will have to fork Blaze temporary if no release coming soon.

@denihs
Copy link
Contributor

denihs commented Nov 14, 2024

Blaze@3.0.1 is out!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Missing resolve properties when handle #with with promise
4 participants