-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Promise
s in #with
(closes #469).
#471
Conversation
Interesting... They all passed locally. |
Any idea when this PR will be merged and available? |
I think someone with permissions needs to rerun the CI or at least check on it. @denihs do you have access to the circleci and check why this failed with this very weird error message? |
I tried that locally again and it worked. Then I restarted it and it fails now. I have no idea what's going on, but will try to fix it. |
@radekmie thanks for fixing this 👍 |
Hi, |
I can merge but publishing is on the side of the Meteor core team // cc @denihs |
@denihs any idea when a potential |
Blaze@3.0.1 is out!! |
As mentioned in #469 (comment), this PR adds support for
Promise
s in#with
blocks, just like #424 did that for#if
and#each
.Note that due to the way
#with
is implemented, it takes two "cycles" (i.e.,await
s) to fully propagate those results. That should not be a problem, as#with
is discouraged anyway.