Use custom Meteor 1.6.1.1 build of Node 8.11.1. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 8.10.0 and 8.11.0 also suffer from the segmentation fault problem that was fixed by this custom build, but no version of Meteor has (or will) ever ship with either of those versions of Node, so 8.11.1 is the only Node version we need to worry about. Issues that should be fixed once this change is deployed: meteor/meteor#9797 https://meteor.zendesk.com/agent/tickets/12197 https://meteor.zendesk.com/agent/tickets/12195 https://meteor.zendesk.com/agent/tickets/12216 https://meteor.zendesk.com/agent/tickets/12218
glasser
reviewed
Apr 5, 2018
| curl -sSLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz" \ | ||
| && tar -xzf "node-v$NODE_VERSION-linux-x64.tar.gz" -C / \ | ||
| && rm "node-v$NODE_VERSION-linux-x64.tar.gz" | ||
| if [ "$NODE_VERSION" == "8.11.1" ] |
There was a problem hiding this comment.
Maybe we should preinstall this one into the base image (by adding an install_node.sh invocation to the Dockerfile)? Esp since this isn't coming from a CDN. Hopefully we won't be triggering the npm bug described in the Dockerfile.
zzwong
approved these changes
Apr 5, 2018
glasser
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official Node 8.11.1 still suffers from the segmentation fault problem reported in nodejs/node#19274, because 8.11.0 was a security release that did not include the necessary patch, and 8.11.1 was a release without any additional commits.
To fix the problem in development, Meteor 1.6.1.1 comes with a custom build of Node 8.11.1 with one additional commit. However, Galaxy does not use this custom build of Node 8.11.1, but instead uses the official build, which can lead to segmentation faults in production.
Node 8.10.0 and 8.11.0 also suffer from the segmentation fault problem that was fixed by this custom build, but no version of Meteor has (or will) ever ship with either of those versions of Node, so 8.11.1 is the only Node version we need to worry about.
Issues that should be fixed once this change is deployed:
meteor/meteor#9797
https://meteor.zendesk.com/agent/tickets/12197
https://meteor.zendesk.com/agent/tickets/12195
https://meteor.zendesk.com/agent/tickets/12216
https://meteor.zendesk.com/agent/tickets/12218