Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to version 8.11.1 (with v8 patch). #9783

Closed
wants to merge 5 commits into from

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Mar 29, 2018

Supersedes #9725.

Node just released version 8.11.0, a security update, which unfortunately did not contain the fix for the segmentation fault problems that we discovered in #9725 and worked with them to fix in nodejs/node#19274. That fix will presumably come in Node 8.11.1.

In the meantime, we've built a version of Node 8.11.0 with just that one fix applied: https://github.com/meteor/node/commits/v8.11.0-meteor

This should allow us to move to release candidate testing for Meteor 1.6.2 while we wait for the official Node 8.11.1 release. 🤞⏳

@benjamn benjamn added this to the Release 1.6.2 milestone Mar 29, 2018
@benjamn benjamn changed the title Update Node to version 8.11.0 (with v8 patch). Update Node to version 8.11.1 (with v8 patch). Mar 30, 2018
@benjamn
Copy link
Contributor Author

benjamn commented Mar 30, 2018

Update: Node has already released an 8.11.1 version with no additional commits, so I guess we'll be waiting for 8.11.2 instead!

Copy link
Contributor

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

(Also, yay ICU download flag.)

@benjamn benjamn mentioned this pull request Mar 31, 2018
@benjamn
Copy link
Contributor Author

benjamn commented Mar 31, 2018

Superseded by #9789.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants