Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Subscription cancellation #124

Merged
merged 3 commits into from
Mar 4, 2024
Merged

feat: Subscription cancellation #124

merged 3 commits into from
Mar 4, 2024

Conversation

azhur
Copy link
Contributor

@azhur azhur commented Mar 3, 2024 •
edited
Loading

Description

  • make subscription status computable field based on timestamps
  • cancel subscription (at the end of billing period)
  • activate subscription on stripe paid invoice

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

@azhur azhur marked this pull request as ready for review March 3, 2024 18:55
@azhur azhur requested review from gaspb and vmorarian March 3, 2024 18:55
@azhur azhur merged commit 58483ec into main Mar 4, 2024
6 checks passed
@azhur azhur deleted the subscription_cancelation branch March 4, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaspb gaspb gaspb approved these changes

@vmorarian vmorarian Awaiting requested review from vmorarian

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azhur @gaspb