Skip to content

Commit

Permalink
Fix test_datetime on Windows
Browse files Browse the repository at this point in the history
Issue python#29100: On Windows, datetime.datetime.fromtimestamp(min_ts) fails with an
OSError in test_timestamp_limits().
  • Loading branch information
vstinner committed Feb 10, 2017
1 parent 6f37e36 commit 2a35c93
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Lib/test/datetimetester.py
Original file line number Diff line number Diff line change
Expand Up @@ -1997,8 +1997,9 @@ def test_timestamp_limits(self):
# date 0001-01-01 00:00:00+00:00: timestamp=-62135596800
self.assertEqual(self.theclass.fromtimestamp(min_ts, tz=timezone.utc),
min_dt)
except OverflowError as exc:
# the date 0001-01-01 doesn't fit into 32-bit time_t
except (OverflowError, OSError) as exc:
# the date 0001-01-01 doesn't fit into 32-bit time_t,
# or platform doesn't support such very old date
self.skipTest(str(exc))

# maximum timestamp: set seconds to zero to avoid rounding issues
Expand Down

0 comments on commit 2a35c93

Please sign in to comment.