-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use continue instead of pass & implement tests for vert_coords.py
#1049
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1049 +/- ##
============================================
+ Coverage 78.59% 78.67% +0.08%
============================================
Files 125 126 +1
Lines 19964 20069 +105
============================================
+ Hits 15690 15789 +99
- Misses 4274 4280 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change covered by the test suite?
No, it has been specifically excluded from the testing coverage. This is probably not desired anymore. Line 136 in 7de51e0
|
Will need to write tests for First step is add to test coverage. |
The code coverage indicates we are not testing this module. There is no |
There seem to be a number of functions in
|
vert_coords.py
da9f473
to
e7aac0f
Compare
3b4fbeb
to
ea169a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good effort, please work a bit more on the tests
Removes the following functions which aren't used from vert_coords.py: - `is_supported()` - `pressure2altitude()`
80451f0
to
9b0e0cc
Compare
dd085c0
to
114bf89
Compare
While fixing the CR issues I discovered that there were a number of references to code I had previously removed remaining in the code. These were not called in the code, and mostly used here which is an elif clause which always raises an exception, and is thus unlikely to be part of the program flow. I've cut out most of that clause, as well as any logic related to the |
I do not understand what are you trying to say hare. |
It is basically cleaning up left overs from my original cleanup. I had removed some functions, but missed functions which called on the removed functions. This didn't surface because that path is only in the mentioned elif clause. This just removes the remaining dangling references. So in short, yes, I removed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🎆
test.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this file?
are the methods here the same as the ones on vert_coords
?
Change Summary
Fixes
pass
instead ofcontinue
error invert_cords.py
and increases test coverage ofvert_coords.py
by implementing tests and removing unused code.Related issue number
NA
Checklist