Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3 mda8 #1165

Closed
wants to merge 2 commits into from
Closed

O3 mda8 #1165

wants to merge 2 commits into from

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented May 8, 2024

Change Summary

Related issue number

fix #863

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the enhancement ✨ New feature or request label May 8, 2024
@thorbjoernl thorbjoernl added this to the m2024-06 milestone May 8, 2024
@thorbjoernl thorbjoernl self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (af621d8) to head (d718577).
Report is 1 commits behind head on main-dev.

Current head d718577 differs from pull request most recent head e74e6d3

Please upload reports for the commit e74e6d3 to get more accurate results.

Files Patch % Lines
pyaerocom/io/mscw_ctm/additional_variables.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1165      +/-   ##
============================================
- Coverage     79.25%   78.76%   -0.50%     
============================================
  Files           129      127       -2     
  Lines         20220    20120     -100     
============================================
- Hits          16025    15847     -178     
- Misses         4195     4273      +78     
Flag Coverage Δ
unittests 78.76% <93.33%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refactor

Cleanup code

Remove stuff
@lewisblake
Copy link
Member

Idea: O3 and CO both need MDA8. Therefore maybe making an operator which takes a ColocatedData object and applies for example a daily maximum of the 8 hourly mean (MDA8) could be useful. Would need to be specified in a config, and then dealt with here (similar to how we use use_fairmode):

use_fairmode = self.cfg.statistics_opts.use_fairmode

@lewisblake
Copy link
Member

Want a way to keep both the original timeseries and the MDA8. Expand ColocatedDataList?

@thorbjoernl
Copy link
Collaborator Author

Working on a new branch so closing this PR. New PR: #1224

@thorbjoernl thorbjoernl mentioned this pull request Jun 24, 2024
9 tasks
@thorbjoernl thorbjoernl deleted the o3-mda8 branch August 19, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDA8
2 participants