rose suite-run proposal #2412
Closed
rose suite-run proposal #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
commented
Sep 30, 2020
| write_source_vc_info( | ||
| suite_conf_dir, "log/" + prefix + ".version", self.popen) | ||
|
|
||
| # If run through rose-stem, install version information | ||
| # files for each source tree if they're a working copy | ||
| ## keep |
There was a problem hiding this comment.
@dpmatthews has suggested we remove this from Rose and build it directly into Cylc.
This could be an additional Cylc plugin with git/svn support.
|
Good - the proof of the pudding will be... |
|
The comments all look reasonable at this stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: Don't merge
Related to cylc/cylc-flow#3819
Proposal covering
rose suite-runfunctionality migration to the new Cylc plugin.run_implfunctionality out of Rose into the plugin (wherever that eventually resides).rose-suite-run.login the Rose plugin.