Code

Refactor CubeCombiner#1383

Code

Merged

MoseleyS merged 10 commits intometoppv:mastermetoppv/improver:masterfrom cgsandford:refactor_combinecgsandford/improver:refactor_combineCopy head branch name to clipboardDec 16, 2020

+302-238

Commits

Commits on Dec 8, 2020

• Factored multiplication case out of CubeCombiner. All CLI tests pass. Need to sort unit tests and then make code nicer.

  cgsandford

  committed
  206e5ae

  Copy full SHA for 206e5ae

• Split existing unit tests between plugins and they pass.

  cgsandford

  committed
  f752730

  Copy full SHA for f752730

• Reduced "broadcast_to_coords" to "broadcast_to_threshold" boolean, consistent with use case and CLI interface.

  cgsandford

  committed
  b5adaed

  Copy full SHA for b5adaed

• Simplified setting up of coords for broadcast to use threshold only.

  cgsandford

  committed
  ad7611e

  Copy full SHA for ad7611e

• Factored out broadcasting into CubeMultiplier. Coord checking needs tidying up but all tests pass.

  cgsandford

  committed
  a038f96

  Copy full SHA for a038f96

• Removed unused method.

  cgsandford

  committed
  dec97f8

  Copy full SHA for dec97f8

• Pythonified coordinate checking.

  cgsandford

  committed
  4adf926

  Copy full SHA for 4adf926

• Removed "self.operation" and summarised use more clearly.

  cgsandford

  committed
  6452ff5

  Copy full SHA for 6452ff5

• Addressed comments from first review.

  cgsandford

  committed
  c85478c

  Copy full SHA for c85478c

Commits on Dec 15, 2020

• Response to second review.

  cgsandford

  committed
  e6c68a7

  Copy full SHA for e6c68a7