Add multiple conda environments #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with pySTEPS may be resolved in #1389. |
Codecov Report
@@ Coverage Diff @@
## master #1392 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 89 89
Lines 7614 7614
=======================================
Hits 7337 7337
Misses 277 277 Continue to review full report at Codecov.
|
The previous environment.yml file is now environment_py3.6_iris2.2.yml and there is an additional Python 3.7 and Iris 2.4 env. Both envs are tested via GitHub Actions. Two tests for wind components required reduced precision to pass unit tests.
dmentipl
force-pushed
the
multiple_envs_sub
branch
from
56690f2 to
06d8838
Compare
tjtg
requested changes
Dec 22, 2020
This was causing the wrong environment to be used.
tjtg
previously approved these changes
Jan 4, 2021
There was a problem hiding this comment.
I'm happy with the updated branch here - looks like it's addressed all the items I mentioned previously and the tests are passing on github actions with both environments.
I've run the acceptance test suite with both 3.6/2.2 and 3.7/2.4 environments and the test failures match those already identified in issue #1397 and PR #1398.
btrotta-bom
reviewed
Jan 5, 2021
See metoppv#1398.
tjtg
approved these changes
Jan 5, 2021
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Add multiple conda environments The previous environment.yml file is now environment_py3.6_iris2.2.yml and there is an additional Python 3.7 and Iris 2.4 env. Both envs are tested via GitHub Actions. Two tests for wind components required reduced precision to pass unit tests. * Fix bug in workflows introduced in prev commit * Fix hashFiles bug in workflow * Update instructions to create environments * Remove previous environment.yml file * Pin pySTEPS version to pass unit tests * Hash specific environment file in tests This was causing the wrong environment to be used. * Fix GitHub Actions syntax * Re-add safety and bandit to environment files * Reset cache in GitHub Actions * Fix use of hashFiles in tests.yml * Remove dots from env file names and tidy tests.yml * Give environments different names * Source conda environment per step in tests.yml * Fix path for caches in tests.yml * Add fail-fast is false to tests.yml * Reset cache * Only run Codestyle-and-Pylint in Python 3.7 env * Pin scipy See metoppv#1398.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1381
Add multiple conda environments in a new directory "envs" and test each in CI.
The existing conda environment file (environment.yml) is renamed environment_py3.6_iris2.2.yml and there is an additional Python 3.7 and Iris 2.4 environment. Both environments are tested via GitHub Actions.
Two tests for wind components required reduced precision to pass unit tests. The Python 3.7 environment required pinning pySTEPS to 1.3.2.
Testing:
Note: this pull request contains the changes implemented in #1385. So this can be considered a draft until that is merged.