Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump codecov/codecov-action from 3 to 4" #1978

Merged

Conversation

cpelley
Copy link
Contributor

@cpelley cpelley commented Jan 22, 2024

Reverts #1942

@cpelley cpelley self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b60bf10) 98.40% compared to head (fbdead8) 98.40%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1978   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         124      124           
  Lines       12067    12067           
=======================================
  Hits        11874    11874           
  Misses        193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but in ignorance of what is actually going on.

  • What was Dependabot trying to achieve by incrementing this value?
  • Will this happen again? If so, how can we prevent it?

@cpelley
Copy link
Contributor Author

cpelley commented Jan 22, 2024

  • What was Dependabot trying to achieve by incrementing this value?

Ensuring we use the latest action version. The github action UI becomes stale over time and we should be using the latest version of an action to ensure that it is functions as intended.

  • Will this happen again? If so, how can we prevent it?

A consequence of an unofficial action which removed a v4 release after it was created.
codecov/codecov-action#1089 for more context.

Hopefully shouldn't happen in future.

@cpelley cpelley merged commit c43ec0a into master Jan 22, 2024
18 checks passed
@cpelley cpelley deleted the revert-1942-dependabot/github_actions/codecov/codecov-action-4 branch January 22, 2024 11:39
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Jan 22, 2024
* master:
  Revert "Bump codecov/codecov-action from 3 to 4" (metoppv#1978)
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants