Restrict fragment-spread map to be required (#13)

metosin · Jun 6, 2024 · 9c91edc · 9c91edc
1 parent 130d9d5
commit 9c91edc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/oksa/parse.cljc b/src/oksa/parse.cljc
@@ -137,11 +137,11 @@
                 [:fn #(not (@reserved-keywords %))]]
    ::FragmentSpread [:cat
                      [:enum :oksa/fragment-spread :...]
-                     [:? [:map
-                          [:name {:optional false}
-                           [:ref ::FragmentName]]
-                          [:directives {:optional true}
-                           [:ref ::Directives]]]]]
+                     [:map
+                      [:name {:optional false}
+                       [:ref ::FragmentName]]
+                      [:directives {:optional true}
+                       [:ref ::Directives]]]]
    ::InlineFragment [:cat
                      [:enum :oksa/inline-fragment :...]
                      [:? [:map

diff --git a/test/oksa/core_test.cljc b/test/oksa/core_test.cljc
@@ -133,7 +133,8 @@
   (t/testing "fragment spread"
     (t/is (= "{foo ...bar}"
              (unparse-and-validate [:foo [:... {:name :bar}]])
-             (unparse-and-validate [:foo [:oksa/fragment-spread {:name :bar}]]))))
+             (unparse-and-validate [:foo [:oksa/fragment-spread {:name :bar}]])))
+    (t/is (thrown? #?(:clj Exception :cljs js/Error) (unparse-and-validate [[:oksa/fragment-spread]]))))
   (t/testing "inline fragment"
     (t/is (= "{foo ...{bar}}"
              (unparse-and-validate [:foo [:... [:bar]]])