Remove hard dependency on ClojureScript #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l Clojure project.
|
Hmm, I see I forgot to run the ClojureScript tests. Is there an alternate impl to get around the analyzer require? |
|
I provided a macro impl of |
miikka
suggested changes
May 10, 2017
| @@ -1,4 +1,4 @@ | |||
| (defproject metosin/spec-tools "0.1.0" | |||
| (defproject metosin/spec-tools "0.1.1" | |||
There was a problem hiding this comment.
Could you remove this? I'd prefer to not have version bumps in PRs, and it should be to a -SNAPSHOT release first anyway.
|
I fixed the version myself, merged it and made a release. Thanks for the contribution! |
|
No problem. Thanks for your work on this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec-tools v0.1.0 places a hard dependency on ClojureScript. Trying to load
spec-tools.corein an all Clojure project results in this error:The ClojureScript analyzer is required in impl.cljc. Does ClojureScript need to be a hard dependency? If not, here is a PR removing the
requirefor the CLJS analyzer in Clojure code.