Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes invalid error logging #94

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fixes invalid error logging #94

merged 1 commit into from
Feb 1, 2024

Conversation

leftieFriele
Copy link
Contributor

This PR resolves issue #93 which describes how the error logging does not follow the contract of abslog and thereby removing the error from the log if using a logger like pino.

Closes #93

Copy link
Collaborator

@trygve-lie trygve-lie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@leftieFriele leftieFriele merged commit 3bbc95c into main Feb 1, 2024
10 checks passed
@leftieFriele leftieFriele deleted the invalid-error-log branch February 1, 2024 08:11
Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 4.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages are not logged properly
3 participants