Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the metrics-observer protobufs up to date #345

Merged
merged 6 commits into from
Apr 5, 2023
Merged

Commits on Feb 27, 2023

  1. Bring the metrics-observer protobufs up to date

    Aligned the proto file in the observer sub-crate with the one in
    the TCP exporter. Updated the observer message handling code to use
    the new structures. This format de-sync will occur again if the writer
    code is changed without also updating the observer. The right solution
    here is to have the two crates share the protobuf file, but that
    requires more structural tinkering than a newcomer to the project
    should do :).
    
    Satisfied the clippy lints complaining about type complexity by
    creeating some subtypes.
    ceejbot committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    e271f60 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Clean up qualified type names.

    The prost generated message wrapper type is named `Event`, and this
    overlaps with our metrics Event type that is in its payload. Named
    the wrapper `ProstMessage` to make its meaning more clear. This one
    is only used once and might reasonably be used fully-qualified inline.
    
    Also, fixed the typo in MetadataValue.
    ceejbot committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c2e66f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Configuration menu
    Copy the full SHA
    aec2dce View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. stylistic changes

    tobz committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    50aaa4e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into main

    tobz authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f779b13 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into main

    tobz authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a4caf29 View commit details
    Browse the repository at this point in the history