Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy lints #510

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Fix clippy lints #510

merged 5 commits into from
Aug 28, 2024

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Aug 25, 2024

No description provided.

tobz
tobz reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@tobz tobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments and nits.

metrics-exporter-prometheus/src/exporter/http_listener.rs Show resolved Hide resolved
metrics-exporter-prometheus/src/exporter/http_listener.rs Show resolved Hide resolved
metrics-exporter-prometheus/src/formatting.rs Outdated Show resolved Hide resolved
metrics-exporter-prometheus/tests/http_listener_integration_test.rs Show resolved Hide resolved
metrics-tracing-context/src/tracing_integration.rs Show resolved Hide resolved
metrics-util/src/layers/router.rs Outdated Show resolved Hide resolved
metrics-util/src/registry/recency.rs Show resolved Hide resolved
metrics-exporter-prometheus/src/exporter/builder.rs Show resolved Hide resolved
clippy.toml Show resolved Hide resolved
@tobz tobz added C-exporter Component: exporters such as Prometheus, TCP, etc. C-util Component: utility classes and helpers. C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-chore Type: chore. labels Aug 26, 2024
@joshka
Simplify prometheus sanitization
b7cb2ad 
Use positive validity checks and iterators rather than negative and for loop
@joshka
Fix router test
6eb34fd 
Ensure that String is tested
@tobz tobz merged commit 55273f0 into metrics-rs:main Aug 28, 2024
13 checks passed
@tobz tobz added the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Aug 28, 2024
@joshka joshka deleted the jm/clippy branch August 31, 2024 23:09
tobz pushed a commit that referenced this pull request Sep 21, 2024
@joshka @tobz
Fix clippy lints (#510)
5460b3f 
Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>
@tobz
Copy link
Member

tobz commented Oct 12, 2024

Released as part of metrics@v0.24.0/metrics-util@v0.18.0/metrics-tracing-context@v0.17.0/metrics-exporter-prometheus@v0.16.0.

Thanks again for your contribution!

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobz tobz tobz left review comments

Assignees
No one assigned
Labels
C-core Component: core functionality such as traits, etc. C-exporter Component: exporters such as Prometheus, TCP, etc. C-util Component: utility classes and helpers. E-simple Effort: simple. T-chore Type: chore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @tobz