Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixed up documentation for Level::* constants #524

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix mixed up documentation for Level::* constants #524

merged 1 commit into from
Oct 3, 2024

Conversation

AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Oct 2, 2024

No description provided.

tobz
tobz approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@tobz tobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I can't believe I missed this during code review when this code was first introduced. 🤦🏻

Thanks for catching this!

@tobz tobz merged commit c06d68e into metrics-rs:main Oct 3, 2024
4 checks passed
@tobz tobz added C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-bug Type: bug. S-awaiting-release Status: awaiting a release to be considered fixed/implemented. labels Oct 3, 2024
@AMDmi3 AMDmi3 deleted the documentation-fix branch October 3, 2024 20:06
@tobz
Copy link
Member

tobz commented Oct 12, 2024

Released as part of metrics@v0.24.0.

Thanks again for your contribution!

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobz tobz tobz approved these changes

Assignees
No one assigned
Labels
C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-bug Type: bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMDmi3 @tobz