Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for include_tafd to FALSE #29

Closed
kylebaron opened this issue Apr 22, 2021 · 0 comments · Fixed by #28
Closed

Change default for include_tafd to FALSE #29

kylebaron opened this issue Apr 22, 2021 · 0 comments · Fixed by #28
Assignees
@kylebaron
Labels
low-risk refactor
Milestone
v0.4.0

Comments

@kylebaron
Copy link
Collaborator

kylebaron commented Apr 22, 2021 •
edited
Loading

Summary

As a user, I don't want lastdose to automatically write TAFD, but rather write time of first dose

Tests

  • tests/testthat/test-lastdose.R
    • time after first dose
@kylebaron kylebaron self-assigned this Apr 22, 2021
@kylebaron kylebaron added this to the Next Release milestone Apr 22, 2021
@kylebaron kylebaron changed the title Replace TOFD with TAFD Change default for include_tafd to FALSE Apr 24, 2021
@kylebaron kylebaron mentioned this issue Apr 24, 2021
Merged
@kylebaron kylebaron mentioned this issue May 13, 2021
Merged
@kylebaron kylebaron linked a pull request May 13, 2021 that will close this issue
Features and fixes #28
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylebaron kylebaron

Labels
low-risk refactor
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Features and fixes metrumresearchgroup/lastdose
1 participant
@kylebaron