Features and fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebaron
changed the title
barrettk
approved these changes
May 12, 2021
R/lastdose.R
Outdated
| comments <- rep(comments,nrow(data)) | ||
| } | ||
| if(!length(comments)==nrow(data)) { | ||
| stop("'comments' must be have length equal to the number of rows in 'data'",call.=FALSE) | ||
| if(!length(comments) == nrow(data)) { |
There was a problem hiding this comment.
Is this:
if(!length(comments) == nrow(data)) {
identical to:
if(length(comments) != nrow(data)) {
When I run !length(comments) by itself I get FALSE, so wanted to confirm the functionality.
There was a problem hiding this comment.
Seemed to work as designed, just hadn't seen that syntax before
This was
linked to
issues
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add option
lastdose.include_tafdadd option
lastdose.id_coladd option
lastdose.time_colhandle missing values in time column
include_tafdnow defaults toFALSEtests for handling missing values in TIME
search for ID column using
find_id_col()search for time column using
find_time_col()See #25, #27, #29, #30