Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features and fixes #28

Merged
merged 12 commits into from
May 13, 2021
Merged

Features and fixes #28

merged 12 commits into from
May 13, 2021

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Feb 11, 2021

Summary

  • add option lastdose.include_tafd

  • add option lastdose.id_col

  • add option lastdose.time_col

  • handle missing values in time column

  • include_tafd now defaults to FALSE

  • tests for handling missing values in TIME

  • search for ID column using find_id_col()

  • search for time column using find_time_col()

See #25, #27, #29, #30

@kylebaron kylebaron changed the title [WIP] options for id_col and time_col [WIP] Features and fixes Apr 24, 2021
@kylebaron kylebaron linked an issue Apr 24, 2021 that may be closed by this pull request
@kylebaron kylebaron changed the title [WIP] Features and fixes Features and fixes Apr 24, 2021
@kylebaron kylebaron linked an issue Apr 24, 2021 that may be closed by this pull request
@kylebaron kylebaron requested a review from barrettk May 11, 2021 00:33
Copy link
Contributor

@barrettk barrettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

R/lastdose.R Outdated
comments <- rep(comments,nrow(data))
}
if(!length(comments)==nrow(data)) {
stop("'comments' must be have length equal to the number of rows in 'data'",call.=FALSE)
if(!length(comments) == nrow(data)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this:

  if(!length(comments) == nrow(data)) {

identical to:

  if(length(comments) != nrow(data)) {

When I run !length(comments) by itself I get FALSE, so wanted to confirm the functionality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to work as designed, just hadn't seen that syntax before
image

@kylebaron kylebaron requested a review from barrettk May 12, 2021 20:14
@kylebaron kylebaron merged commit e3510d0 into develop May 13, 2021
@kylebaron kylebaron deleted the feature/easy-input branch May 13, 2021 13:20
Copy link
Contributor

@barrettk barrettk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants