Fix variable type handling for mypy #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 14.71% 18.40% +3.68%
==========================================
Files 14 15 +1
Lines 1026 788 -238
==========================================
- Hits 151 145 -6
+ Misses 875 643 -232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aarmey
requested changes
May 21, 2024
junit.xml
Outdated
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="utf-8"?><testsuites><testsuite name="pytest" errors="0" failures="1" skipped="0" tests="1" time="4.159" timestamp="2024-05-21T01:12:28.597684" hostname="aretha"><testcase classname="bicytok.test.test_model" name="test_optimize_design" time="2.761"><failure message="TypeError: optimizeDesign() got an unexpected keyword argument 'vals'">def test_optimize_design(): | |||
There was a problem hiding this comment.
Don't think this should have been committed. Delete.
bicytok/MBmodel.py
Outdated
| @@ -11,13 +11,13 @@ def getKxStar(): | |||
|
|
|||
|
|
|||
| def cytBindingModel( | |||
| recCount: np.ndarray, recXaffs: np.ndarray, dose: float, vals: np.ndarray | |||
| recCount: np.ndarray, recXaffs: np.ndarray, dose: float, vals: list | |||
There was a problem hiding this comment.
Can't this be an nd.ndarray if it's just converted to such in the function?
bicytok/MBmodel.py
Outdated
| ): | ||
| """Runs binding model for a given mutein, valency, dose, and cell type.""" | ||
| # Check that values are in correct placement, can invert | ||
| Kx = getKxStar() | ||
| ligandConc = dose / (vals[0] * 1e9) | ||
|
|
||
| output = polyc(ligandConc, Kx, recCount, [vals], recXaffs)[0] | ||
| output = polyc(ligandConc, Kx, recCount, np.array([vals]), recXaffs)[0] |
There was a problem hiding this comment.
Can just pass Vals here without modification.
aarmey
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.