Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rector to update to php7.4 #220

Closed
wants to merge 2 commits into from
Closed

Use rector to update to php7.4 #220

wants to merge 2 commits into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Feb 14, 2024

Mostly adding void return types, fixing the list() to [] syntax, and using the ::class instead of hard-coded strings.

@meyfa
Copy link
Owner

meyfa commented Feb 15, 2024

@tacman Thanks for the PR! I've merged #218 and #212. Could I bother you to rebase this PR onto main and/or run the tool again to solve the conflicts? 😅

Changes look good to me on a surface-level. I'll take a more detailed look once conflicts are resolved.

@meyfa
Copy link
Owner

meyfa commented Feb 15, 2024

Closing in favor of #221

@meyfa meyfa closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants