Update SVGPolygonalShape.php, trimm points attribute from trailing spaces #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, very much appreciated! |
|
Tagged as release 0.5.4. |
ptsavdar
added a commit
to ptsavdar/php-svg
that referenced
this pull request
Feb 27, 2017
* Trim polygon points attribute when parsing (meyfa#23) * Fix `SVGRect::setHeight()` setting the width * Add support for `<image>` tag (meyfa#26) * Add SVGImageRenderer for embedded images Can render URLs as well as data URIs. * Add SVGImageElement for `<image>` tag * Suppress unavoidable PHPMD warnings [in the above commits] * Review fixes * Added xmlns:xlink attr to SVG document * Added xmlns:xlink attr to test * Added xmlns:xlink attr to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes $attrs['points'] contain trailing spaces in the end or beginning of string which results to an error (undefined index). Trimmed those spaces to solve the issue.