Deprecates KalibroModule#module_results #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoamc
force-pushed
the
kalibro_module_module_results_endpoint
branch
from
5761980 to
fc5dfa2
Compare
|
Could you create an issue to remove this deprecated method? And what do you think about we start a milestone that will hold issues related to deprecations? |
|
CHANGELOG? |
This is an ActiveRecord method that existed when a KalibroModule 'had many' ModuleResults. Our business logic changed and now a KalibroModule 'belongs to' only one ModuleResult. Our next major release should remove this deprecation. Adds CHANGELOG.
diegoamc
force-pushed
the
kalibro_module_module_results_endpoint
branch
from
fc5dfa2 to
d172c98
Compare
|
Issue created and CHANGELOG added. |
|
Nice! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ActiveRecord method that existed when a KalibroModule 'had
many' ModuleResults. Our business logic changed and now a KalibroModule
'belongs to' only one ModuleResult.
Our next major release should remove this deprecation.
Notice that when we remove that deprecation, we will need to change our KalibroModule controller accordingly.