RouteCollector: Detect Duplicates Config #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames configuration option for detect duplicates from `[RouteCollector::class]['detect_duplicates']` to `['router']['detect_duplicates']` Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
v4/detect-duplicates-config
branch
from
88465d4
to
0e6b4d8
Compare
Ocramius
approved these changes
Jul 18, 2024
| @@ -21,6 +22,8 @@ | |||
| */ | |||
| final class RouteCollectorFactory | |||
| { | |||
| private const DETECT_DUPLICATES_BY_DEFAULT = true; | |||
There was a problem hiding this comment.
I had to squint a few times, because adding a constant for this felt a bit excessive, but then it makes sense :-)
Comment on lines
-53
to
+56
| if (! isset($config[RouteCollector::class])) { | ||
| return true; | ||
| } | ||
| $options = $config['router'] ?? []; |
There was a problem hiding this comment.
Do we need to adjust any docs for this?
There was a problem hiding this comment.
Yes #62 is tracking this - but I think all the docs are in mezzio - I'll write some decent release notes on the 4.0 milestone here so that we can refer to them when updating docs for the next mezzio major 👍
There was a problem hiding this comment.
Also added mezzio/mezzio#183 to mezzio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames configuration option for detect duplicates from
[RouteCollector::class]['detect_duplicates']to['router']['detect_duplicates']Reference: #62