Add composer create-project test to GitHub Actions

[zonuexe]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

refs #114 (comment)

Add a GitHub Action that reproduces the behavior of composer create-project.

[zonuexe]

laminas/laminas-ci-matrix-action says An actions/checkout step prior to this action is not required, but requires an explicit checkout action to execute the command in the next step.

[zonuexe]

I left a way to reproduce the behavior using a git archive in #114 (comment), but I found that this way I could test it using a real composer create-project command.

This time the project is created based on the local path instead of the version published on Packagist, which can be verified by truncating the file path in OptionalPackages::preparePhpunitConfig().

For some reason composer creates test-new-project as a symlink instead of creating a new directory, which is fine for a working check.

[zonuexe]

This test cannot rely on the matrices provided by laminas-continuous-integration-action, so it only checks @lowest and @latest.

[zonuexe]

@Ocramius This PR is ready, please review it.

[weierophinney]

I was unsure why you were using the CI action, and then realized it will auto-identify the lowest and highest supported PHP versions, as well as any extensions required, ensuring the composer operation will run.

The only "issue" I see is that it doesn't demonstrate selecting different packages when prompted. That could be an improvement for a later revision, though.

One other thing that might be interesting is having some assertions on completion: validating configuration is correct, etc.

However, I think this is a great addition, and I'm happy to 🚢 now, and iterate and improve from here!

[boesing]

LGTM.
Not sure why the CI action is added, even tho it would install extensions (within the CI container), it has no effect to the runner where you run the create-project command.

What PHP versions are @lowest and @latest pointing to in GHA? Not sure if it is a good idea to use these instead of the supported PHP versions from within the composer.json as they might change over time while the composer.json might not.

However, good enough for me.

[gsteel]

LGTM! However, might it be easier here to drop the laminas matrix action and use https://github.com/WyriHaximus/github-action-composer-php-versions-in-range to generate a matrix of PHP versions to check?

[zonuexe]

It is possible to replace that action. However, rather than adding a dependency on third-party Actions, I believe that Laminas community-maintained Action is more reliable.

[boesing]

It is possible to replace that action. However, rather than adding a dependency on third-party Actions, I believe that Laminas community-maintained Action is more reliable.

I understand your concern, but using laminas-ci-action just boots the CI container while not executing anything in there. So its actually just like sleep(10); exit 0; and brings no value to the current setup you are providing with this PR.

Why did you add the CI action in the first place? Maybe if I understand the reason, we can provide a better fix.

BTW: We as laminas do not really care if something is provided from us or from a trustworthy upstream project. IMHO, the wyrhaximus GHA has proper reputation and can be used properly as the user is working with PHP for ages now 👍🏼

---

Just to clarify: https://github.com/mezzio/mezzio-skeleton/actions/runs/3857405715/jobs/6574764223#step:3:8
Thats the step where the CI container is being executed and it says "nothing to execute" as there is no JOB JSON payload passed to the container. The create-project is not executed in the laminas-ci container but on the GHA runner. Therefore, you can safely remove laminas-ci-container as a step and the GHA output would remain the same.

You can also add php --version right before you run composer create-project. This will help to debug which PHP version is being used when you are expecting @lowest or @latest (I still do not know what these aliases are pointing to from a GHA PoV).

[Ocramius]

🚢 here

Better done good than done perfect 👍

[Ocramius]

Fun stuff: this failed post-merge 🤣