-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Continuous integration should be properly executed #57
Conversation
15fd098
to
4520991
Compare
This will ensure that we do not end up having the `MezzioInstaller` executed while running CI. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This also replaces `phpstan/phpstan` with `vimeo/psalm`. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
4520991
to
2047d07
Compare
@boesing I tried to resolve the errors that were occuring in your CI runs, got confused, and decided to start from scratch. I started by removing prophecy and switching to native PHP mock objects, following your examples as closely as possible. What I ended up with was that the TemplateRenderersTest and the HomePageResponseTest had failures, and I was utterly unable to resolve them. I started by getting errors about So, I removed the annotation... and the first run for a given template renderer case would pass, but then it would start failing, generally for all other cases. From what I could tell, it was an issue due to caching of the
I can run each of those tests individually, and they pass. Running them as part of the test suite, they fail (due to cached class declarations). Running them in isolated processes fails (due to oddities with autoloading). I'm not sure why this changes simply by switching from prophecy to native mocks. If I could resolve the |
Closing in favor of #63 - I managed to get things sorted! |
Description
This will ensure that the CI pipeline for this project will run as expected. This also shows that Auryn container (as mentioned in #53) is not compatible with
mezzio/mezzio
(anymore).This PR also contains the following changes:
phpstan/phpstan
vimeo/psalm
phpspec/prophecy
composer.lock
as part of the asset removal