-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from PHPStan to Psalm #63
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
373fddd
feat: remove Prophecy usage
weierophinney fb44204
qa: remove phpstan from project
weierophinney f492f17
qa: add Psalm to CI pipeline
weierophinney af38c2f
feat: remove Psalm dependencies and configuration during installation
weierophinney 4c63fbc
qa: create Psalm baseline and apply automated ruleset
weierophinney bf140de
qa: make it possible to run phpcs, and apply autofixes
weierophinney 65b71ed
qa: ensure dependencies are installed correctly and phpcs can run in …
weierophinney 6cfb6d1
qa: bump minimum supported mezzio/mezzio-tooling version
weierophinney 229030c
qa: bump minimum supported PHPUnit to 9.5.11
weierophinney ce4dc51
qa: ignore resources and config when running Psalm
weierophinney 3195759
fix: bump vfsstream minimum version to 1.6.10
weierophinney 2756602
fix: bump pimple to latest supported version
weierophinney b6de910
qa: do not ignore platform reqs for PHP 8.0, 8.1
weierophinney 33bcc58
qa: replace tabs with spaces in composer.json
weierophinney 8b2ed15
fix: remove psalm baseline on installation
weierophinney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
{ | ||
"additional_composer_arguments": [ | ||
"--no-scripts", | ||
"--no-plugins" | ||
], | ||
"ignore_php_platform_requirements": { | ||
"8.1": true | ||
"8.0": false, | ||
"8.1": false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
#!/bin/bash | ||
|
||
# Due to the fact that we are disabling plugins when installing/updating/downgrading composer dependencies | ||
# we have to manually enable the coding standard here. | ||
composer enable-codestandard |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've indicated that the
--ignore-platform-requirement
flag should NOT be used with PHP 8.0 and 8.1.composer update
operations run normally without the flag, and, when using--prefer-lowest
, we need to get requirements that are appropriate for those versions (otherwise, tests fail due to syntax errors!).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, if the property
ignore_php_platform_requirements
is available, all PHP versions will havefalse
by default.So it would be enough to simply create the property as an empty object to ensure that platform reqs won't be ignored.
If the
ignore_php_platform_requirements
property is not available, PHP 8.0 will always have ignored platform reqs.